login view update #178
Open
login view update #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have resolved the branch conflicts which were arising previously. Kindly review now sir @khannakshat7 |
|
@sreetu Please resolve the conflicts |
|
I have deleted the duplicate code and so, conflict has been resolved. |
|
@sreetu Any update on this? |
@khannakshat7 sir, I have resolved the conflicts. |
|
I think there is some mistake in this PR have a look
|
|
this PR is removing one of the most important code on that page |
|
there is a code for error / success msg after the div having id myTabContent but this PR is removing it. Please allow me to make a PR for this |
|
@khannakshat7 please assign me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issuse
Closes: #166 [issue number that will be closed through this PR]
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
I have added 'requied' tag in the input forms of the login page to make them as madatory field
Checklist:
Screenshots