Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add text and tooltip for copy success msg #16

Closed
wants to merge 7 commits into from

Conversation

sk-pathan
Copy link

fix:#1672

what pr do
This pull request aims to enhance the user experience and streamline the development process by introducing two key features: "Try Deploy Locally" button and "Copy Tooltip for Success Message."

Changes Proposed:

Added "Try Deploy Locally" button to enable users to test deployments locally before committing changes.
Implemented a copy tooltip for success messages, providing users with clear feedback upon successful copy actions.

mobile view:
https://github.com/keploy/website/assets/141400463/c4f462ea-383a-4dc6-a47b-6adb55d56230

laptop view:

laptop1672.mp4

@sk-pathan
Copy link
Author

hey @nehagup and @Hermione2408 review my changes

@Hermione2408
Copy link
Member

Hey @sk-pathan
It is breaking in medium size please check
Screenshot from 2024-03-31 14-30-29
Also please use "try keploy locally" color according to theme mentioned in README

@sk-pathan
Copy link
Author

hey @Hermione2408 ,
I have fixed the issue and for colour of text i change the colour but you have better idea please let me know
image

@Hermione2408
Copy link
Member

Hey @sk-pathan I noticed the second gif is overlapping in the medium size view. Also, there's inconsistency with the text color across different views; please make it consistent to text-secondary-300
Screenshot from 2024-04-01 17-04-55

@sk-pathan
Copy link
Author

hi @Hermione2408 have look on change

Copy link
Member

@Hermione2408 Hermione2408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-04-03 11-43-25
Hey @sk-pathan In medium size, now gif is not aligned with the side div

@@ -94,9 +107,23 @@ const CopyCode = () => {

return (
<>
<p className='font-bold text-secondry-300'>Try Keploy Locally </p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secondary*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk-pathan please correct this spelling mistake the class is not getting applied

Copy link
Member

@Hermione2408 Hermione2408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey due to fixed height to the image the gap in third gif is a lot in small screen can you make it more responsive?
Screenshot from 2024-04-05 16-30-06

@@ -94,9 +107,23 @@ const CopyCode = () => {

return (
<>
<p className='font-bold text-secondry-300'>Try Keploy Locally </p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk-pathan please correct this spelling mistake the class is not getting applied

@sk-pathan
Copy link
Author

sk-pathan commented Apr 10, 2024

@Hermione2408
Black and White Groovy Keep Going Desktop Wallpaper

Signed-off-by: sk-pathan <[email protected]>
@Hermione2408
Copy link
Member

Hey @sk-pathan, this issue is now closed keploy/keploy#1672. Thanks for your contributions I am closing this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants