fix/overlapping items #13
Conversation
Signed-off-by: Ethan Water <[email protected]>
|
Hey @ethanwater there is conflict in your PR please resolve it |
|
@Hermione2408 Conflicts resolved. |
|
|
|
Ah, this is because of formatting errors post conflict revisions. I can just fmt to fix this. Or manually remove the spaces. Silly conflicts. |
|
@Hermione2408 The native integration image has been replaced? Are these changes even necessary anymore. This issue can probably be closed. Moving on. |
Hey @ethanwater this issue persists on medium and small screen size |
Signed-off-by: Ethan Water <[email protected]>
|
@Hermione2408 The version you sent me is outdated since #4 , as you can see here: https://keploy.io. But as I said before, the code I submitted for the original version works as you can see below. However since #4 , this PR and the image you provided is outdated by 4 days. Unless we plan to use the original style (the style you show in the image you just sent), then this PR can be closed. If not, then it can be merged. I would also like to mention that I like the changes @sahadat-sk made in his PR towards the look and feel of the section in question. My Changes (Pre PR #4 ): Actual Public Keploy.io Site (Post PR #4 ): Either way, if you would like to test this branch, then it has been updated for you to do so. |
There was a problem hiding this comment.
@ethanwater thanks for the initiative! This is needs to be resolved for the md and sm screen size where there's old layout of features, which looks to be solved in this PR. However, for larger screen sizes, please revert back the layout to what @sahadat-sk implemented :)
Signed-off-by: Ethan Water <[email protected]>
|
@nehagup anytime! I just updated the code to ensure there is no overlapping for the native integration image, while maintaining the layout @sahadat-sk made. |
Fixes: keploy/keploy#1698
Super simple. All I did was remove the 'md:max-w-none' property to prevent item overlapping. It's worth noting that it seems a segment of the transition system may be a bit off due to a difference between initial height and post-leave height. However, this specific issue has been fixed.