Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keploy Integration - Added sample Java application using JWT Token #76

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jaiakash
Copy link

Pull Request Template

Description

Hi me (@jaiakash) and @amitpanwar789 have worked on the sample Java application with JWT token creation and verification. This sample helps to use the Keploy to test in JAVA.

Fixes keploy/keploy#2016

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@jaiakash
Copy link
Author

Please review @Swpn0neel @charankamarapu

@charankamarapu
Copy link
Member

I have tried running the application without keploy. On the second request which is mentioned in the README is giving me this error

Screenshot 2024-07-26 at 1 20 33 PM

It is better to keep the token in header than request body (a standard practice).

@jaiakash
Copy link
Author

Hi @charankamarapu Thanks for your suggestion. Have updated the PR to have token in header instead of body.
Also as I can see from screenshots, end point is users/tokenVerification not users/verify

Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

spring-boot-jwt/README.md Outdated Show resolved Hide resolved
spring-boot-jwt/README.md Outdated Show resolved Hide resolved
spring-boot-jwt/README.md Show resolved Hide resolved
spring-boot-jwt/README.md Outdated Show resolved Hide resolved
spring-boot-jwt/README.md Show resolved Hide resolved
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments and before requesting for a review please follow the read me and add the record and test screenshots for native and docker case.

spring-boot-jwt/README.md Outdated Show resolved Hide resolved
- Login

```bash
curl --location --request POST 'http://localhost:8080/users/login' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the native case removed ..?

These should be the headings

Prerequisites
Getting Started
Native Usage
Docker Usage

  • here only you can write the command to build application image etc.

we dont need API Endpoints/ Running with Docker section

spring-boot-jwt/keploy.yml Show resolved Hide resolved
spring-boot-jwt/README.md Outdated Show resolved Hide resolved
@jaiakash
Copy link
Author

jaiakash commented Aug 5, 2024

Hi @yaten2302, did you check it?

@yaten2302
Copy link

Apologies for the delay, @jaiakash. I've DM you on Slack.

jaiakash and others added 8 commits September 10, 2024 03:15
Signed-off-by: Akash Jaiswal <[email protected]>
Signed-off-by: Pranshu Srivastava <[email protected]>
Signed-off-by: Akash Jaiswal <[email protected]>
* feat:Add spring-mysql-redis to samples java

Signed-off-by: Hermione Dadheech <[email protected]>

* remove .idea and target folder

Signed-off-by: Hermione Dadheech <[email protected]>

* add .idea and target to gitignore

Signed-off-by: Hermione Dadheech <[email protected]>

* add .idea and target to gitignore

Signed-off-by: Hermione Dadheech <[email protected]>

* remove reports from .gitignore

Signed-off-by: Hermione Dadheech <[email protected]>

---------

Signed-off-by: Hermione Dadheech <[email protected]>
Signed-off-by: Akash Jaiswal <[email protected]>
Signed-off-by: Akash Jaiswal <[email protected]>
@jaiakash
Copy link
Author

jaiakash commented Sep 9, 2024

Hi @PranshuSrivastava @Sonichigo @charankamarapu, I am incredibly sorry for the delay.

Have updated the PR. Can you please suggest what changes are required in this readme file or maybe the overall project?

Thanks

cc @yaten2302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Creating Sample Java Application using JWT Token
5 participants