Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish to pip workflow #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

PranshuSrivastava
Copy link
Contributor

@PranshuSrivastava PranshuSrivastava commented Feb 15, 2024

Issue that this pull request solves

Brief description of what is fixed or changed

Currently the workflow to publish a release to pip is not working correctly. This is because the setup.py file is in a subdirectory and not in the root. Specifying that subdirectory in the workflow to fix that.

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Other information

Any other information that is important to this pull request

@Sarthak160
Copy link
Member

@PranshuSrivastava I have made changes to append the pypi as prefix and also extracted version from the github release itself. If you are done with your changes lets try to release by merging this action.

@Sonichigo
Copy link
Member

@Sarthak160 please resolve the conflictes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants