Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): add cairo-lint #276

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat(ci): add cairo-lint #276

wants to merge 5 commits into from

Conversation

bloomingpeach
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Nov 2, 2024

@bloomingpeach is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

@b-j-roberts
Copy link
Contributor

Nice! Would you be able to fix existing lint warnings as part of this PR so the CI passes?

@bloomingpeach
Copy link
Contributor Author

@b-j-roberts I think the currentcairo-lint isn't ready to be integrated to the CI, while fixing I encountered several false positives

@b-j-roberts
Copy link
Contributor

Alright, thank you for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts Awaiting requested review from b-j-roberts b-j-roberts will be requested when the pull request is marked ready for review b-j-roberts is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bloomingpeach @b-j-roberts