-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually create a sitemap.xml for docs SEO #4261
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dmitry Sorokin <[email protected]>
Signed-off-by: Dmitry Sorokin <[email protected]>
@@ -223,6 +223,8 @@ | |||
# We've decided to rely on RTD's default robots.txt, so we no longer need to specify a custom one, | |||
# see discussion at https://github.com/kedro-org/kedro/issues/3741 | |||
# html_extra_path = [str(here / "robots.txt")] | |||
html_extra_path = [str(here / "sitemap.xml")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 So this was it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I checked the build, and it didn’t help. Something is still overwriting the sitemap.xml
, even with that line included.
Signed-off-by: Dmitry Sorokin <[email protected]>
Signed-off-by: Dmitry Sorokin <[email protected]>
Signed-off-by: Dmitry Sorokin <[email protected]>
After adding
I also tried adding a custom |
Signed-off-by: Dmitry Sorokin <[email protected]>
Description
Draft PR currently, checking RTD build
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file