Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Feature branch for refactor node list #2193

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Oct 29, 2024

  1. Refactor / node list row (#2143)

    * update classnames to match the component name
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update names in tests
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update the rest of the classnames
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * abstract node-list-row-toggle component
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * tidy up code for toggle component
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update classnames in tests
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * simplify the css
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * add tests for node-list-row-toggle
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove handleToggle on VisibilityIcon
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove redux from node-list-row
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * split node-list-row into row and filter-row
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * rename toggle icon component
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * move row and filter-row to components level
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * move css to row and filterRow
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove node-list-row
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * separate the row-text component
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * include parent classname
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update name for toggle-icon, to visibility-control
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fix css and move nodeListRowHeight to config
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * adding test for new component
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update classname for tests
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * move row inside node-list
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * connect redux store to component
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fix styling
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update name to ToggleControl
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove disable props as no longer needed
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * replace js code with css to simplify the code
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update classnames in cypress test
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * Styling for hovering and focus mode
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fixing small styling
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fix the disable styling for row
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fix the disable styling on focus mode
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove one of the old test
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update name for icons for FilterRow
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fixing the icon highlighting issue
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove un-used li element
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove styling for pipeline-nodelist__placeholder-upper and lower class as nolonger used
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update test in node-list
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update cypress tests
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * moving .pipeline-nodelist__group--all-unchecked to the parent
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * prevent page reload on form submission
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove wrong classname in the test
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove unique ID
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * apply hovering styling on the parent instead of row
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * styling for selected element
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fixing hover styling on the icon from MUI
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    ---------
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    Co-authored-by: Huong Nguyen <huongg1409@gmail>
    Huongg and Huong Nguyen authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2c36a43 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Refactor/node list groups (#2166)

    * Create new structure and its own folder for filters or groups
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * better names for component structure
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * FiltersSectionHeading
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * filters-section
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * filters component
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * filtersSectionHeading component
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * tidy up code
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * including new tests for new components
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update and remove existing tests
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove un-used variables
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove components folder
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update tests path
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    ---------
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    Co-authored-by: Huong Nguyen <huongg1409@gmail>
    Huongg and Huong Nguyen authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    61c1de3 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Refactor/node list index (#2178)

    * foundation for FiltersContext
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * remove unused props
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * node-list-context
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * restructure node-list-item as a helper function
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * rename selectors
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * rename functions in FiltersContext
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * move redux selector to node-list-context
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fixing the hovered node issue
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * move getFilteredItems to selector
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fix the modularpipeline highlight issue
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * Adding test for selector
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update tests
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update names to be nodes-panel
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * Fixing the filters problem
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update test
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fixing the highlight issue through getNodesActive
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * move node-list-tree to its own component
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update row to node-list-row
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * move style to be inside node-list-tree
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * fix the filters URL update
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    * update name for nodes panel context
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    
    ---------
    
    Signed-off-by: Huong Nguyen <huongg1409@gmail>
    Co-authored-by: Huong Nguyen <huongg1409@gmail>
    Huongg and Huong Nguyen authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    637c5ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa6c8cb View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Refactor on NodeListTree (#2177)

    This is a smaller refactor. Previously, the logic for determining which nodes were disabled due to modular pipelines was duplicated in both the NodeListTree component and the getNodeDisabled selector. To improve maintainability and reduce redundancy, the getnodesDisabledViaModularPipeline logic was extracted and made into it's own selector. Now, this logic is shared and reused by both the NodeListTree component and the getNodeDisabled selector.
    rashidakanchwala authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f27384a View commit details
    Browse the repository at this point in the history