Not running govet or gofmt in Dockerfile builds (#1283)

* Not running govet or gofmt in Dockerfile builds Signed-off-by: Aaron Schlesinger <[email protected]> * not running go-vet in precommit Signed-off-by: Aaron Schlesinger <[email protected]>
kedacore · Dec 7, 2020 · 0626a20 · 0626a20
1 parent af2b36f
commit 0626a20
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -26,7 +26,7 @@ COPY pkg/ pkg/
 COPY .git/ .git/
 
 # Build
-RUN VERSION=${BUILD_VERSION} make manager
+RUN VERSION=${BUILD_VERSION} make manager-dockerfile
 
 # Use distroless as minimal base image to package the manager binary
 # Refer to https://github.com/GoogleContainerTools/distroless for more details

diff --git a/Dockerfile.adapter b/Dockerfile.adapter
@@ -28,7 +28,7 @@ COPY .git/ .git/
 RUN mkdir -p /apiserver.local.config/certificates && chmod -R 777 /apiserver.local.config
 
 # Build
-RUN VERSION=${BUILD_VERSION} make adapter
+RUN VERSION=${BUILD_VERSION} make adapter-dockerfile
 
 # Use distroless as minimal base image to package the manager binary
 # Refer to https://github.com/GoogleContainerTools/distroless for more details

diff --git a/Makefile b/Makefile
@@ -136,14 +136,28 @@ docker-build:
 
 # Build KEDA Operator binary
 .PHONY: manager
-manager: generate gofmt govet
+manager: manager-dockerfile gofmt govet
+
+# Build the manager inside the Dockerfile. This elides
+# the gofmt and govet commands. Since code quality checks
+# are already in CI, we don't need to run them every
+# time we build the image
+.PHONY: manager-dockerfile
+manager-dockerfile: generate
 	${GO_BUILD_VARS} go build \
 	-ldflags "-X=github.com/kedacore/keda/version.GitCommit=$(GIT_COMMIT) -X=github.com/kedacore/keda/version.Version=$(VERSION)" \
 	-o bin/keda main.go
 
 # Build KEDA Metrics Server Adapter binary
 .PHONY: adapter
-adapter: generate gofmt govet
+adapter: adapter-dockerfile gofmt govet
+
+# Build the adapter inside the Dockerfile. This elides
+# the gofmt and govet commands. Since code quality checks
+# are already in CI, we don't need to run them every
+# time we build the image
+.PHONY: adapter-dockerfile
+adapter-dockerfile: generate
 	${GO_BUILD_VARS} go build \
 	-ldflags "-X=github.com/kedacore/keda/version.GitCommit=$(GIT_COMMIT) -X=github.com/kedacore/keda/version.Version=$(VERSION)" \
 	-o bin/keda-adapter adapter/main.go