Termit-UI #423 remove unused terms

README.md

@@ -77,7 +77,7 @@ Then, TermIt can be run and exposed at the port 8080 as
 
 An optional argument is `<GRAPHDB_REPOSITORY_URL>` pointing to the RDF4J/GraphDB repository.
 
-TermIt Docker images are also build and published to [DockerHub](https://hub.docker.com/r/kbsscvut/termit).
+TermIt Docker images are also published to [DockerHub](https://hub.docker.com/r/kbsscvut/termit).
 
 ## Links
 

src/main/java/cz/cvut/kbss/termit/rest/TermController.java

@@ -395,22 +395,6 @@ public void removeTerm(
         LOG.debug("Term {} removed.", termUri);
     }
 
-    @Operation(security = {@SecurityRequirement(name = "bearer-key")},
-               description = "Gets terms from the vocabulary with the specified identifier that are not used in any document of definition")
-    @ApiResponses({
-            @ApiResponse(responseCode = "200", description = "Unused terms."),
-            @ApiResponse(responseCode = "404", description = "Vocabulary not found.")
-    })
-    @GetMapping(value = "/vocabularies/{localName}/unused-terms",
-                produces = {MediaType.APPLICATION_JSON_VALUE, JsonLd.MEDIA_TYPE})
-    public List<URI> getUnusedTermsInVocabulary(
-            @Parameter(description = ApiDoc.ID_LOCAL_NAME_DESCRIPTION, example = ApiDoc.ID_LOCAL_NAME_EXAMPLE)
-            @PathVariable String localName,
-            @Parameter(description = ApiDoc.ID_NAMESPACE_DESCRIPTION, example = ApiDoc.ID_NAMESPACE_EXAMPLE)
-            @RequestParam(name = QueryParams.NAMESPACE, required = false) Optional<String> namespace) {
-        return termService.getUnusedTermsInVocabulary(getVocabulary(getVocabularyUri(namespace, localName)));
-    }
-
     @Operation(security = {@SecurityRequirement(name = "bearer-key")},
                description = "Gets sub-terms of the term with the specified local name in the vocabulary with the specified identifier")
     @ApiResponses({

src/main/java/cz/cvut/kbss/termit/rest/handler/RestExceptionHandler.java

@@ -19,7 +19,6 @@
 import cz.cvut.kbss.termit.exception.AnnotationGenerationException;
 import cz.cvut.kbss.termit.exception.AssetRemovalException;
 import cz.cvut.kbss.termit.exception.AuthorizationException;
-import cz.cvut.kbss.termit.exception.DisabledOperationException;
 import cz.cvut.kbss.termit.exception.InvalidLanguageConstantException;
 import cz.cvut.kbss.termit.exception.InvalidParameterException;
 import cz.cvut.kbss.termit.exception.InvalidTermStateException;
@@ -159,13 +158,6 @@ public ResponseEntity<ErrorInfo> unsupportedAssetOperationException(HttpServletR
         return new ResponseEntity<>(errorInfo(request, e), HttpStatus.CONFLICT);
     }
 
-    @ExceptionHandler(DisabledOperationException.class)
-    public ResponseEntity<ErrorInfo> disabledOperationException(HttpServletRequest request,
-                                                                DisabledOperationException e) {
-        logException(e);
-        return new ResponseEntity<>(errorInfo(request, e), HttpStatus.CONFLICT);
-    }
-
     @ExceptionHandler(VocabularyImportException.class)
     public ResponseEntity<ErrorInfo> vocabularyImportException(HttpServletRequest request,
                                                                VocabularyImportException e) {

src/main/java/cz/cvut/kbss/termit/service/business/TermService.java

@@ -526,16 +526,6 @@ private void checkForInvalidTerminalStateAssignment(Term term, URI state) {
         }
     }
 
-    /**
-     * Gets terms not occurring in any resources or other terms definitions.
-     *
-     * @return List of term identifiers
-     */
-    public List<URI> getUnusedTermsInVocabulary(Vocabulary vocabulary) {
-        Objects.requireNonNull(vocabulary);
-        return repositoryService.getUnusedTermsInVocabulary(vocabulary);
-    }
-
     @Override
     public List<AbstractChangeRecord> getChanges(Term term) {
         Objects.requireNonNull(term);

src/main/java/cz/cvut/kbss/termit/service/repository/TermRepositoryService.java

@@ -20,7 +20,6 @@
 import cz.cvut.kbss.termit.dto.assignment.TermOccurrences;
 import cz.cvut.kbss.termit.dto.listing.TermDto;
 import cz.cvut.kbss.termit.exception.AssetRemovalException;
-import cz.cvut.kbss.termit.exception.DisabledOperationException;
 import cz.cvut.kbss.termit.exception.UnsupportedOperationException;
 import cz.cvut.kbss.termit.model.Term;
 import cz.cvut.kbss.termit.model.Vocabulary;
@@ -367,16 +366,6 @@ public List<TermOccurrence> getDefinitionallyRelatedOf(Term instance) {
         return termOccurrenceDao.findAllDefinitionalOf(instance);
     }
 
-    /**
-     * Gets all unused (unassigned to, neither occurring in a resource) terms in the given vocabulary
-     *
-     * @param vocabulary - IRI of the vocabulary in which the terms are
-     * @return List of definitionally related terms of the specified term
-     */
-    public List<URI> getUnusedTermsInVocabulary(Vocabulary vocabulary) {
-        throw new DisabledOperationException("This method is disabled, not working correctly.");
-    }
-
     /**
      * Removes a term if it: - does not have children, - is not related to any resource, - is not related to any term
      * occurrences.

src/test/java/cz/cvut/kbss/termit/service/business/TermServiceTest.java

@@ -51,7 +51,6 @@
 import java.util.stream.Stream;
 
 import static cz.cvut.kbss.termit.environment.Generator.generateTermWithId;
-import static cz.cvut.kbss.termit.environment.Generator.generateVocabulary;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.hasItems;
 import static org.hamcrest.Matchers.lessThan;
@@ -340,16 +339,6 @@ void updateInvokesTextAnalysisOnUpdatedTerm() {
         verify(textAnalysisService).analyzeTermDefinition(toUpdate, toUpdate.getVocabulary());
     }
 
-    @Test
-    void getUnusedTermsReturnsUnusedTermsInVocabulary() {
-        final List<URI> terms = Collections.singletonList(Generator.generateUri());
-        final Vocabulary vocabulary = generateVocabulary();
-        when(termRepositoryService.getUnusedTermsInVocabulary(vocabulary)).thenReturn(terms);
-        final List<URI> result = sut.getUnusedTermsInVocabulary(vocabulary);
-        assertEquals(terms, result);
-        verify(termRepositoryService).getUnusedTermsInVocabulary(vocabulary);
-    }
-
     @Test
     void setTermDefinitionSourceSetsTermOnDefinitionAndPersistsIt() {
         final Term term = Generator.generateTermWithId();