Make s-forms compatible with new version of s-forms-editor #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compatibility with s-forms-editor.
✅ Deploy Preview for s-forms-kbss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
blcham
requested changes
May 3, 2022
| @@ -6,7 +6,7 @@ import FormUtils from "../../util/FormUtils"; | |||
| import YASQE from "yasgui-yasqe"; | |||
| import YATE from "yasgui-yasqe"; | |||
| import { ConfigurationContext } from "../../contexts/ConfigurationContext"; | |||
| import "@triply/yasgui/build/yasgui.min.css"; | |||
There was a problem hiding this comment.
@LaChope I am not sure why we do that ... so what are consequences of this decision?
I assume this:
- we did not depend on styling of yasgui component and thus whenever we upgrade new version of yasgui, we need to remember to also generate yasgui.min.css as well
- so what did we get in return? did we need to modify yasgui ? (If so why do we add minified version and not well formated version?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changed are made to make s-forms compatible with s-forms-editor