Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values in typeahead are dissapearing from the dropdown in storybook #218

Closed
blcham opened this issue Jul 12, 2023 · 2 comments
Closed

Values in typeahead are dissapearing from the dropdown in storybook #218

blcham opened this issue Jul 12, 2023 · 2 comments

Comments

@blcham
Copy link
Collaborator

blcham commented Jul 12, 2023

image

It behaves as follows:

  • when I select 3 ---> 0 is missing
  • when I select 4 ---> 0,1 is missing
  • when I select "Not allowed" ---> 0,1,2 is missing

Tested on:
https://deploy-preview-217--s-forms-kbss.netlify.app/?path=/story/stories-forms--tourist-destination-form-2&globals=locale:cs;timeOut:200

@blcham blcham changed the title Values in typeahead are dissapearing from the dropdown Values in typeahead are dissapearing from the dropdown in storybook Jul 12, 2023
@VojtechLunak
Copy link
Collaborator

VojtechLunak commented Jul 13, 2023

Seems that this issue was also in PR #203. Storybook preview

Might be related to the form json.

Also, in current storybook preview - storybook - the issue is even weirder. The clicking does not always select the value. That might be connected to the migration to React 18 and react-select from v3 to v5.

So to summarize:
In s-forms v0.4.1 (storybook)

  • can normally select value, but other select options disappear in specific scenarios (test value 3 clicked => accepted value option disappears)

In s-forms v0.6.4

  • can normally select value, but other select options disappear in specific scenarios (mentioned in the first comment in this issue)

In s-forms v0.7.0

  • only some clicks result in selecting the option
  • when selection happens, other select options dissapear as in v0.6.4

@blcham
Copy link
Collaborator Author

blcham commented Nov 16, 2023

Closing, solved by #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants