Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree autocomplete does not allow to select values by keyboard #258

Closed
blcham opened this issue Jan 24, 2024 · 7 comments · Fixed by #265
Closed

Tree autocomplete does not allow to select values by keyboard #258

blcham opened this issue Jan 24, 2024 · 7 comments · Fixed by #265
Assignees

Comments

@blcham
Copy link
Collaborator

blcham commented Jan 24, 2024

  • we might use the original component for autocomplete (react-select) for simple values (having something like layout-class "simple-typeahead"), but only in case if the old react-select component worked fine

@LaChope

@LaChope
Copy link
Collaborator

LaChope commented Jan 24, 2024

@blcham Here is the ticket for removing Select component: #218

@LaChope LaChope self-assigned this Jan 24, 2024
@LaChope
Copy link
Collaborator

LaChope commented Jan 30, 2024

@blcham I need to better understand the use case.

  1. Does this need to work for record-manager-ui (so in the branch downgrade-react-17)?
  2. Does it need to work for the tree also or only without tree?

@blcham
Copy link
Collaborator Author

blcham commented Jan 31, 2024

Ad 1) No we need it only for main branch
Ad 2) It should be possible to select the value without the use of the mouse. We need to investigate first how hard it is to implement it in the tree and based on that we can decide if we support it only for list or also support it for the tree.

@LaChope
Copy link
Collaborator

LaChope commented Jan 31, 2024

Simple typeahead should have flag: FLAT_TYPEAHEAD: "flat-typeahead"

@LaChope
Copy link
Collaborator

LaChope commented Feb 1, 2024

@blcham PR was created there lecbyjak/intelligent-tree-select#73

edit: When navigating with keyboard, focus of navigated option is lost if there is the scrollbar

@LaChope
Copy link
Collaborator

LaChope commented Feb 1, 2024

@blcham intelligent-tree-select is using virtualization (via react-window dependency), this is why the focus is lost when navigating with keyboard. Here is interesting issue to follow: bvaughn/react-window#650

@LaChope
Copy link
Collaborator

LaChope commented Feb 20, 2024

@blcham We can merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants