Feature/65 support fault event model with fha and sns properties #68
Conversation
| ### http://onto.fel.cvut.cz/ontologies/fta-fmea-application/from | ||
| fta-fmea:from rdf:type owl:DatatypeProperty ; | ||
| rdfs:domain fta-fmea:failure-rate-requirement . | ||
|
|
||
|
|
||
| ### http://onto.fel.cvut.cz/ontologies/fta-fmea-application/has-ata-code | ||
| fta-fmea:has-ata-code rdf:type owl:DatatypeProperty . |
There was a problem hiding this comment.
We need to discuss naming conventions and how hard it would be to refactor everything with those conventions. It won't be most-likely easier than now.
Conventions from CSAT:
- entities contain only small letters, with words separated by "-" (even classes)
- object properties should start with :has-
- datatype properties typically do not start with :has-
There was a problem hiding this comment.
I do not see a problem of refactoring. The only problem I see is that existing data won't be compatible and would need to be refactored as well.
However, I suggest to do this in a separate ticket.
There was a problem hiding this comment.
I suggest to do this in a separate ticket.
The only problem I can see is that we will have to also refactor old data, for example data in fta-fmea-demo.
I have some reservation for the proposed naming conventions:
- object properties should start with 'has' - in my opinion some properties do not need it. For example,
:activatedByshould be refactored as:has-activated-by. I would prefer to refactor it as:activated-by.
There was a problem hiding this comment.
activates
is-activated-by
has-activating-behaviour
There was a problem hiding this comment.
Conventions will be solved by issue kbss-cvut/fta-fmea-ui#198
kostobog
force-pushed
the
feature/65-support-fault-event-model-with-fha-and-sns-properties
branch
from
3798901
to
e6df4d0
Compare
|
Let's agree on how it should be refactored in kbss-cvut/fta-fmea-ui#198 |
kostobog
force-pushed
the
feature/65-support-fault-event-model-with-fha-and-sns-properties
branch
from
e6df4d0
to
c0f7483
Compare
…and FaultEvent.selectedEstimate
…systems and behaviors with domain entity types and allow adding Event.contextEvents.
kostobog
force-pushed
the
feature/65-support-fault-event-model-with-fha-and-sns-properties
branch
from
c0f7483
to
82573b8
Compare
blcham
deleted the
feature/65-support-fault-event-model-with-fha-and-sns-properties
branch
Resolves #65