Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Artur to the list of package authors #323

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

kbsali
Copy link
Owner

@kbsali kbsali commented Sep 20, 2023

No description provided.

@kbsali kbsali marked this pull request as ready for review September 20, 2023 11:53
@kbsali kbsali requested a review from Art4 September 20, 2023 11:53
Copy link
Collaborator

@Art4 Art4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 😊

composer.json Outdated Show resolved Hide resolved
@kbsali
Copy link
Owner Author

kbsali commented Sep 20, 2023

@Art4 I have tried to setup codecov but it fails at generating the coverage file... not sure how to fix this 🙏

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Art4 Art4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made two suggestions to setup Codecov properly.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@kbsali kbsali merged commit 0c05477 into v2.x Sep 21, 2023
11 checks passed
@kbsali
Copy link
Owner Author

kbsali commented Sep 21, 2023

👍

@Art4 Art4 deleted the chore/add-artur-to-authors branch December 28, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants