ci.ocp: Improve the service-up detection #5807
Conversation
|
I tested (similar) version here: openshift/release#48473 seems to work well. |
ldoktor
force-pushed
the
ocp-curl-fix
branch
3 times, most recently
from
3cfe330
to
6669db0
Compare
|
Hi Lukas - is there a plan to move this openshift testing into the kata-containers repo as the tests repo is deprecated? |
| test_status=$? | ||
| if [ $test_status -eq 0 ]; then | ||
| if waitForProcess 60 1 "curl '${host}:${port}${hello_file}' 2>/dev/null | grep -q '$hello_msg'"; then | ||
| test_status=0 | ||
| info "HTTP server is working" |
There was a problem hiding this comment.
I'd leave out "everything is working" messages from the log if possible.
You're going to check logs when things do not work and the "working" logs get in the way.
If you can't tell where things break in the code, you're typically missing an error test
There was a problem hiding this comment.
Well, this message was already there (and is quite useful when looking for things that do not work, at least you know this thing worked...). Anyway I'd rather move a discussion about this message to another PR, if needed.
ldoktor
force-pushed
the
ocp-curl-fix
branch
from
6669db0
to
c0077ba
Compare
waiting for the first response is not sufficient as OCP returns html page without error even when the route is not yet established describing the issue (why it doesn't reply with 500?). Waiting for the correct output should do better. Fixes: kata-containers#5808 Signed-off-by: Lukáš Doktor <[email protected]>
these logs are vital to analyze a setup failure. Signed-off-by: Lukáš Doktor <[email protected]>
ldoktor
force-pushed
the
ocp-curl-fix
branch
from
c0077ba
to
9060e93
Compare
|
Changes:
Not changed:
|
|
/lgtm |
|
/test |
@stevenhorsman IIUC Lukas is using the test repo as a guinea pig. When everything works, the openshift testing will go the the kata-containers repo like the rest. |
Most of the work is done, now I'm waiting for the 4.13 pipeline issue to be resolved so the openshift/release#48435 can be merged (we actually think about merging it with the failure, depends on the reviewers). Anyway this patchset will have to be backported to kata-containers, I'll take care of it once it's ready. Now it's important to ensure the pipeline works again. |
waiting for the first response is not sufficient as OCP returns html page without error even when the route is not yet established describing the issue (why it doesn't reply with 500?). Waiting for the correct output should do better.