tests/vfio: Extend test to cover cold-plug #7971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix default port assignment with an explicit value in the TOML It was implicit before and now the runtime will bail out if we did not set it explicitly. Update the configuration and set it. This will make the intent more clear. Fixes: kata-containers#5726 Signed-off-by: Zvonko Kaiser <[email protected]> Signed-off-by: Jeremi Piotrowski <[email protected]>
These are not used by the test. Signed-off-by: Jeremi Piotrowski <[email protected]>
This is not implemented (yet) but should be in the config file for overriding in the test case. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
force-pushed
the
vfio-extend-test
branch
from
47bf635
to
05fecb4
Compare
|
Can you add to your commit message, please? Thanks. |
|
This is cool; CLH getting cold-plug support. I will add a runner soon to test this with GPUs. |
|
@jepio should we close the other one if favour of this one? |
|
This PR has been opened without with no activity for 180 days. Comment on the issue otherwise it will be closed in 7 days |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of:
It allows testing cold-plug-vfio and makes the test more parametrized which makes it easier to test GPUs.