Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM89 with variable bump strength #53

Closed
lea-hagen opened this issue Jan 23, 2018 · 4 comments
Closed

CCM89 with variable bump strength #53

lea-hagen opened this issue Jan 23, 2018 · 4 comments

Comments

@lea-hagen
Copy link

There's a nice generalization of CCM89 in the Appendix of Conroy+10 that varies the bump strength. Is adding that (either as its own function or within CCM89) within the scope of this package?

@karllark
Copy link
Owner

I'm not sure. Is the Conroy generalization for integrated measurements of galaxies and regions of galaxies? Or for measurements of individual stars? I have not read the paper yet, so figured I'd just ask!

If it is the the former (integrated measurements), then it should go in the dust_attenuation package. This would provide additional motivation to start this package. I could easily setup all the structure for such a package soon, especially if someone were interested in working on adding attenuation models?

If it is the latter (extinction to single stars), then I would ask how this is different/better than the FM90 or P92 functions? I haven't seen the motivation for this in the extinction curve measurement literature. But I could easily have missed this.

@lea-hagen
Copy link
Author

The Conroy paper is modeling attenuation curves, but they use their generalization of the extinction curve as an attenuation curve (section 3.2.1). Since there's already a discussion of extinction vs attenuation over in #47, I'll just leave it at that.

I would certainly use a dust_attenuation package if it existed (though I'm still not convinced it should be separate). I could probably even add some models!

@karllark
Copy link
Owner

We should put this model in the dust_attenuation package - it exists!
https://github.com/karllark/dust_attenuation

A variable bump in a CCM89 model is not really justified by dust extinction work. For dust extinction curves, if the details of the 2175 A bump are of interest, then the FM90 or P92 formulation are generally used.

@karllark
Copy link
Owner

Created an issue for this model in the dust_attenuation package.

karllark/dust_attenuation#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants