-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Conroy et al. (2010) attenuation model #28
Comments
I don't think it should be in the dust_attenuation package but rather in the dust_extinction package. |
You make good points. I have not looked at this work in detail yet. As it was proposed for attenuation in galaxies, I figured it was best for this package. But we should check. I also have your concern that the FM90 and P92 already provide ways to vary the bump strength. As does G16. So, homework is needed clearly. |
From their work: I believe it strengthens the motivations which lead to the creation of this package ;) Charlie Conroy used the Noll+09 formalism in a more recent paper 2013 with Mariska Kriek. So I don't know whether they are still using the modified ccm89 for galaxies. |
Hum... The clearly argues for adding the Noll model before this one. I can contact Charlie and ask him what he thinks. |
Indeed, It will be interesting to have his point of view. One could use a modified version of the ccm89 recipe to account for this non-universality but as it is based on measurements of individual stars it should be implemented in the dust_extinction package in my opinion. It makes me think that the section "How to choose a model" in the documentation, should address the non-universality of the attenuation law. For instance, for galaxy SED fitting, whenever the spectral coverage allows it (especially rest-frame UV data), the user should use a model with at least one free parameter allowing different UV slopes. |
Really sounds like Noll is the way to go. |
There's a generalization of the CCM89 dust extinction model in the Appendix of Conroy+10 that varies the bump strength to allow for modeling attenuation in galaxies. A possible addition for this package. Originally proposed for the dust_extinction package, but more appropriate here.
karllark/dust_extinction#53
The text was updated successfully, but these errors were encountered: