Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid loading old stunent profiles #138

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

Antoni-Czaplicki
Copy link
Contributor

Vulcan API now receives all old profiles (from previous schools) that are incomplete, this change filters them by "State" field

Copy link
Owner

@kapi2289 kapi2289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's a good idea to allow API user to override this state value? You could introduce a State enum and pass 0 state as a default method parameter.

@Antoni-Czaplicki
Copy link
Contributor Author

I don't really se the use cases for this but I can implement State enum as you suggested.

vulcan/model/_student.py Outdated Show resolved Hide resolved
vulcan/_client.py Show resolved Hide resolved
@kapi2289 kapi2289 merged commit 3f4efd9 into kapi2289:master Apr 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants