-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup makefile #579
Merged
adrianchiris
merged 1 commit into
k8snetworkplumbingwg:master
from
adrianchiris:cleanup-makefile
Jul 25, 2024
Merged
cleanup makefile #579
adrianchiris
merged 1 commit into
k8snetworkplumbingwg:master
from
adrianchiris:cleanup-makefile
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adrianchiris
commented
Jul 24, 2024
•
edited
Loading
edited
- cleanup makefile
- update workflows
- remove deprecated linters from .golangci.yml
- allow to provide additional GO build options, ldflags and flags
Pull Request Test Coverage Report for Build 10079103746Details
💛 - Coveralls |
adrianchiris
force-pushed
the
cleanup-makefile
branch
from
July 24, 2024 12:28
f72f1d6
to
afd9999
Compare
Eoghan1232
reviewed
Jul 24, 2024
Eoghan1232
reviewed
Jul 24, 2024
/test-all |
- cleanup makefile - update workflows - remove deprecated linters from .golangci.yml Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
cleanup-makefile
branch
from
July 24, 2024 15:00
afd9999
to
6fcea71
Compare
Eoghan1232
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ;)
adrianchiris
merged commit Jul 25, 2024
a967ce4
into
k8snetworkplumbingwg:master
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.