-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose RDMA device name in the devicespec if available #530
Merged
SchSeba
merged 1 commit into
k8snetworkplumbingwg:master
from
almaslennikov:expose-rdma-devices
Mar 7, 2024
Merged
Expose RDMA device name in the devicespec if available #530
SchSeba
merged 1 commit into
k8snetworkplumbingwg:master
from
almaslennikov:expose-rdma-devices
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8084092568Details
💛 - Coveralls |
SchSeba
reviewed
Feb 20, 2024
almaslennikov
force-pushed
the
expose-rdma-devices
branch
from
February 28, 2024 16:28
17b9eaf
to
2863bc7
Compare
Signed-off-by: amaslennikov <[email protected]>
almaslennikov
force-pushed
the
expose-rdma-devices
branch
from
February 28, 2024 16:50
2863bc7
to
21c36b7
Compare
/retest |
adrianchiris
approved these changes
Feb 29, 2024
@SchSeba PTAL |
Eoghan1232
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/retest |
SchSeba
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DeviceInfoSpec allows to specify rdma device for a pci device: https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/blob/master/pkg/apis/k8s.cni.cncf.io/v1/types.go#L63
Multus propagates device spec to the network-status, so it's easy to track which RDMA device is allocated to a POD:
This change can serve two purposes: