Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the hashicorp/go-version dependency #14

Merged
merged 10 commits into from
Jan 17, 2024
Merged

Drop the hashicorp/go-version dependency #14

merged 10 commits into from
Jan 17, 2024

Conversation

kke
Copy link
Collaborator

@kke kke commented Jan 12, 2024

(low priority, not in any hurry for a review)

Removes the dependency to hashicorp/go-version.

The API stays the same.

Almost everything was already implemented locally, only needed to implement Compare(*Version) int and version parsing (in NewVersion).

The only dependency now is testify which would be fun to drop too.

@kke kke added enhancement New feature or request go Pull requests that update Go code labels Jan 12, 2024
@kke kke requested a review from twz123 January 12, 2024 14:05
@kke kke mentioned this pull request Jan 15, 2024
@kke kke merged commit 02d6454 into main Jan 17, 2024
1 check passed
@kke kke deleted the drop-hashicorp-dep branch January 17, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants