refactor: Better error handling for harden function (grapheneX#191)

jxdv · Mar 2, 2024 · ca321b6 · ca321b6
1 parent f9614ef
commit ca321b6
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/graphenex/core/hrd/exec.py b/graphenex/core/hrd/exec.py
@@ -18,9 +18,13 @@ def run_cmd(self, cmd, shell=True, **kwargs):
         """
 
         cmd = cmd.replace("$USER", os.environ["USER"])
-        result = subprocess.run(cmd, stdout=subprocess.PIPE, shell=shell, **kwargs)
-        if result.returncode != 0:
-            raise PermissionError
+        try:
+            result = subprocess.run(cmd, stdout=subprocess.PIPE, shell=shell, **kwargs)
+        except subprocess.CalledProcessError as e:
+            raise PermissionError(f"Subprocess err {e} caught while running '{cmd}'")
+        else:
+            if result.returncode != 0:
+                raise PermissionError(f"Command '{cmd}' returned non-zero exit status!")
 
         try:
             return result.stdout.decode('utf-8')