Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sleep events if their duration increases #92

Merged
merged 1 commit into from
May 23, 2024

Conversation

MatthewMazaika
Copy link

the two timestamps being compared were strings, not date objects - they were also in different timezone formats

event["time"]                 => '2024-05-19 23:30:16-05:00'
last_upload["created_at"]     => '2024-05-20T04:30:16.000Z'

after casting the strings to date objects and then doing the comparison, the sleep events get updated properly

i believe this resolves #18

@MatthewMazaika MatthewMazaika changed the title fix: update sleep events if their duration changes fix: update sleep events if their duration increases May 20, 2024
@jwoglom jwoglom merged commit f973f37 into jwoglom:master May 23, 2024
0 of 4 checks passed
@MatthewMazaika MatthewMazaika deleted the update-sleep-events branch May 23, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: track Sleep and Exercise modes in Nightscout
2 participants