Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix choose_device import class name in Heroku Helpers #104

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

zackfern
Copy link
Contributor

@zackfern zackfern commented Oct 3, 2024

This is an attempt to fix the ImportError in issue #102:

  File "/app/app.py", line 4, in <module>
    from utils import token_required, call, setup, get_time_args, run_update, as_text, parse_features
  File "/app/utils.py", line 13, in <module>
    from tconnectsync.sync.tandemsource.heroku_helpers import run_oneshot
  File "/app/.heroku/python/lib/python3.9/site-packages/tconnectsync/sync/tandemsource/heroku_helpers.py", line 2, in <module>
    from .choose_device import TandemSourceChooseDevice
ImportError: cannot import name 'TandemSourceChooseDevice' from 'tconnectsync.sync.tandemsource.choose_device' (/app/.heroku/python/lib/python3.9/site-packages/tconnectsync/sync/tandemsource/choose_device.py)

I believe that TandemSourceChooseDevice is not defined in the project and that the file should instead be importing the ChooseDevice class which is defined in sync/tandemsource/choose_device.py

I am not a Python developer, and unfortunately my attempts at testing this change within the context of tconnectsync-heroku have been unsuccessful, so I have not verified this change! I just hope you can validate this fix based off your experience, and hopefully it saves you a little time. 😄 Thank you!

@jwoglom
Copy link
Owner

jwoglom commented Oct 3, 2024

Looks right! Thanks for catching the typo

@jwoglom jwoglom merged commit 51ac469 into jwoglom:master Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants