Simplify retrieval of encrypted auth state #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there's a public method for this, no need to call decryption methods directly
|
Actually, on re-reading the only discussion of this that I can find here, I think this only came up during the development of the refresh_token auth when the previous launch had the right scopes to request a refresh token, while the latest config does not. I think the right behavior in this situation is to not have a refresh token, since that reflects current config. |
|
I'm slightly less than 100% sure, though. |
manics
approved these changes
Oct 17, 2024
|
Oops, I loaded this page before your most recent comments so didn't see them before merging. |
|
No problem, I think I may end up removing it as part of finishing #579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's a public method for this, no need to call decryption methods directly