Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CILogon] Add allow_all as a idp specific config #684

Merged

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Sep 23, 2023

Without this, a user may be forced to use OAUthenticator v15 to acquire a functionality where all users authenticated by an IDP are allowed, but not all users of another IDP. So in practice, this mitigates a feature regression - where something was possible in oauthenticator 15 that no longer was possible in oauthenticator 16.

Here is an example config where we allow all users from one IDP together with one github user being an admin user.

c.CILogonOAuthenticator.allowed_idps = {
    "https://idpz.utorauth.utoronto.ca/shibboleth": {
        "username_derivation": {
            "username_claim": "email",
        },
        "allow_all": True,
    },
    "https://github.com/login/oauth/authorize": {
        "username_derivation": {
            "username_claim": "preferred_username",
        },
    },
}
c.Authenticator.admin_users = ["some-github-user1"]

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @consideRatio!

@consideRatio consideRatio merged commit 4bad3e8 into jupyterhub:main Sep 25, 2023
8 checks passed
@consideRatio
Copy link
Member Author

Thanks for reviewing @GeorgianaElena!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CILogon] How to authorize all users of one idp but not another - add idp specific allow_all config?
2 participants