-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ORCID iD Authenticator #655
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
Hi! We'd like to avoid adding more single service authenticators due to the maintenance and testing burden. Is there anything in here that can't be done by configuring the GenericAuthenticator? |
Nope! Should a code snippet using Edit: There is the |
A documentation PR would be great! Is it necessary to keep the upper case In general you can't rely on going from the JupyterHub username back to the original username as downstream authenticators/spawners may need to manipulate it in other ways |
Closing this PR.
I can do this. @manics: to what page(s) should this be added?
At least according to my reading of this page, the capital "X" is necessary for recognizing the decimal value of 10 for the checksum.
That's good to know, thank you. If at some point my use case needs the username to map 1-to-1 then I will use the custom authenticator, otherwise |
@matthewwiese There's a page with example configurations:
But there's always room for improving the docs, so let us know if you think there's a better way to present this. |
This PR adds an ORCID iD authenticator class inheriting from
OAuthenticator
, based on the implementation of theGitHubOAuthenticator
class.The tests are rudimentary - I'm happy to implement suggestions from maintainers.
This ought to resolve #284