-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples to null safety #732
Conversation
@timbotimbo can you rebase on my draft PR. Would love to have this merged in |
its ok but like @juicycleff said rebase on his draft PR |
@juicycleff |
Reopening this for visibility, as the global_unity_controller isn't making much progress. |
Flutter will likely come with a new release next week, 3.10 (or maybe 3.12). Therefore I will merge this to keep the example working for people on the latest flutter version. This might cause some small merge conflicts for #733 and #729. But i'd rather help to solve some small merge conflicts, than hastily merge a new feature that might not be stable yet. |
Description
The example code can't simply be pasted into a modern flutter project. It will show errors, mainly due to null-safety changes.
Given that the plugin supports null-safety from version 4.2.0 (18 months ago), it's safe to update the example.
Besides some changes in the UnityWidget parameters, this example project is still compatible all the way back to plugin 4.2.0.
The last commit is a small cleanup by following most suggestions of flutter_lints.
Type of Change