Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop Node 4, 6, 8, 10, 12, 14 & 16 support #3845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelDeBoey
Copy link
Contributor

BREAKING CHANGE: Requires Node@^18.18.0 || ^20.9.0 || >=21.1.0

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Oct 30, 2024

@ljharb Settings should be updated to remove node 4 - 17 from required checks

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (256cf74) to head (89fd797).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3845      +/-   ##
==========================================
+ Coverage   94.11%   97.67%   +3.55%     
==========================================
  Files         133      136       +3     
  Lines        9958     9971      +13     
  Branches     3693     3694       +1     
==========================================
+ Hits         9372     9739     +367     
+ Misses        586      232     -354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelDeBoey MichaelDeBoey force-pushed the drop-Node-4-6-8-10-12-14-16 branch 2 times, most recently from 1930fee to d373485 Compare October 30, 2024 01:44
BREAKING CHANGE: Requires Node@^18.18.0 || ^20.9.0 || >=21.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant