-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix broken link in no-is-mounted.md #3841
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3841 +/- ##
==========================================
- Coverage 97.67% 97.58% -0.09%
==========================================
Files 136 133 -3
Lines 9969 9957 -12
Branches 3693 3693
==========================================
- Hits 9737 9717 -20
- Misses 232 240 +8 ☔ View full report in Codecov by Sentry. |
sigh, facebook broke a bunch of links. there's a dozen other facebook.github.io links in the repo; can you fix all of them? |
Yeah weird that they did not migrate their blog posts. I fixed other links. I was able to replace one with the newer docs. |
@@ -4,7 +4,7 @@ | |||
|
|||
<!-- end auto-generated rule header --> | |||
|
|||
[When using a boolean attribute in JSX](https://facebook.github.io/react/docs/jsx-in-depth.html#boolean-attributes), you can set the attribute value to `true` or omit the value. | |||
When using a boolean attribute in JSX, you can set the attribute value to `true` or omit the value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using a boolean attribute in JSX, you can set the attribute value to `true` or omit the value. | |
When using a [boolean attribute in JSX](https://web.archive.org/web/20160607204033/http://facebook.github.io/react/docs/jsx-in-depth.html#boolean-attributes), you can set the attribute value to `true` or omit the value. |
let's use the original material this linked to instead.
Hi !
The link in
no-is-mounted
is broken.I was able to find the article in the legacy docs.
This PR fixes the link