Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new rule: padding-lines-between-tags #3554 #3789

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

etherealm13
Copy link

@etherealm13 etherealm13 changed the title [New] padding-lines-between-tags: add rule and test cases new rule: padding-lines-between-tags #3554 Jul 22, 2024
@etherealm13
Copy link
Author

@ljharb Let me know your thoughts.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 22.97297% with 57 lines in your changes missing coverage. Please review.

Project coverage is 97.19%. Comparing base (c6fdccd) to head (6eeab0b).

Files Patch % Lines
lib/rules/padding-lines-between-tags.js 22.97% 57 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3789      +/-   ##
==========================================
- Coverage   97.75%   97.19%   -0.57%     
==========================================
  Files         135      136       +1     
  Lines        9715     9789      +74     
  Branches     3527     3553      +26     
==========================================
+ Hits         9497     9514      +17     
- Misses        218      275      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, but in particular, it would need thorough tests.

README.md Outdated Show resolved Hide resolved
docs/rules/padding-lines-between-tags.md Outdated Show resolved Hide resolved
docs/rules/padding-lines-between-tags.md Outdated Show resolved Hide resolved
docs/rules/padding-lines-between-tags.md Outdated Show resolved Hide resolved
docs/rules/padding-lines-between-tags.md Outdated Show resolved Hide resolved
lib/rules/padding-lines-between-tags.js Outdated Show resolved Hide resolved
lib/rules/padding-lines-between-tags.js Outdated Show resolved Hide resolved
@ljharb ljharb marked this pull request as draft July 22, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants