Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the schema of jsx-no-constructed-context-values.js #3766

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fixed the schema of jsx-no-constructed-context-values.js #3766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a0317d
fix schema of jsx-no-constructed-context-values.js
noshiro-pf Jun 12, 2024
81e21f3
fix schema and test
noshiro-pf Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/jsx-no-constructed-context-values.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ module.exports = {
url: docsUrl('jsx-no-constructed-context-values'),
},
messages,
schema: false,
schema: [],
},

// eslint-disable-next-line arrow-body-style
Expand Down
1 change: 0 additions & 1 deletion tests/lib/rules/jsx-no-constructed-context-values.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ ruleTester.run('react-no-constructed-context-values', rule, {
},
{
code: 'function Component() { const foo = useMemo(() => { return {} }, []); return (<Context.Provider value={foo}></Context.Provider>)}',
options: [{ allowArrowFunctions: true }],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i understand that this is incorrect and should be removed.

however, must it be? I'm asking specifically if the schema change causes this to fail. if that's the case for end users, then the schema change is breaking.

},
{
code: `
Expand Down