-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Recategorize rules in readme #3226
base: master
Are you sure you want to change the base?
Conversation
a189556
to
75af0b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #3226 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 121 121
Lines 8519 8519
Branches 3075 3075
=======================================
Hits 8320 8320
Misses 199 199
Continue to review full report at Codecov.
|
2a2d97a
to
793d537
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still feels useful to distinguish jsx-specific rules; not everyone uses jsx with react.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking that best practice is a subjective word. A rule might be a best practice for me but not for other people. If a rule a considered a good practice for 50% of developers, it might considered a best practice among these developers, and considered a stylistic issue among other developers.
It still feels useful to distinguish jsx-specific rules; not everyone uses jsx with react.
I think the prefix in rule names should suffice this need.
I'm not sure that's true, given that some of the jsx rules cover non-jsx as well. As for best practice, of course it's subjective, but its perfectly fine to be opinionated. All of the things I've indicated are prevailing community-wide best practices; if someone disagrees, they are free to disable the rule. |
59af733
to
865ed16
Compare
069314a
to
181c68f
Compare
5d8455f
to
1134494
Compare
Codecov Report
@@ Coverage Diff @@
## master #3226 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 130 130
Lines 9218 9218
Branches 3341 3341
=======================================
Hits 8995 8995
Misses 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
380e32c
to
51d342b
Compare
Closes #3216 .
The categories are taken from https://eslint.org/docs/rules/ .Rendered Readme: https://github.com/yannickcr/eslint-plugin-react/blob/793d5374e09beb34dfcbc4ac3e8494f6ecaf48f1/README.md