Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Div actionverbs withattributes rule #787

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

Div actionverbs withattributes rule #787

wants to merge 35 commits into from

Commits on Feb 19, 2021

  1. div-has-content

    @Felicia5
    Felicia5 committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    ab6b704 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. added div-has-apply

    @Felicia5
    Felicia5 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    5f550a7 View commit details
    Browse the repository at this point in the history

  2. forgot to add rule under src/index.jsx

    @Felicia5
    Felicia5 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    e82f72d View commit details
    Browse the repository at this point in the history

  3. jest test for hasAccessibleChild template, the hasApplyText that is c… 

    …alled in div-has-apply rule
    @Felicia5
    Felicia5 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    0ebad68 View commit details
    Browse the repository at this point in the history

  4. hasApplyText-test looks for divs though not buttons or headings, in d… 

    …i-has-apply-test div with apply should be flagged
    @Felicia5
    Felicia5 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    34c2e3b View commit details
    Browse the repository at this point in the history

  5. published as npm package no. seven

    @Felicia5
    Felicia5 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    21f9563 View commit details
    Browse the repository at this point in the history

  6. replaced div for button jsx elements

    @Felicia5
    Felicia5 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    3ddb61b View commit details
    Browse the repository at this point in the history

  7. published as an npm package version eight

    @Felicia5
    Felicia5 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    080cf36 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. typo in hasApplyText function name

    @Felicia5
    Felicia5 committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    05fd998 View commit details
    Browse the repository at this point in the history

  2. when has child return false for apply literal when jsxelement is div … 

    …- hasApplyText-test
    @Felicia5
    Felicia5 committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    26f6117 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. emoj rule logic: accessing children of div

    @Felicia5
    Felicia5 committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    8a1b816 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. deleted tolowercase, added hasAccessibleChild===false

    @Felicia5
    Felicia5 committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    803cdf7 View commit details
    Browse the repository at this point in the history

  2. div is underlined when text is apply

    @Felicia5
    Felicia5 committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    2e7a7e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. defined case for unknown to run test

    @Felicia5
    Felicia5 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    1799cb9 View commit details
    Browse the repository at this point in the history

  2. actionVerbs variable is created

    @Felicia5
    Felicia5 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    87c84f4 View commit details
    Browse the repository at this point in the history

  3. or in variable doesn't apply, but neither does changing apply to subm… 

    …it text
    @Felicia5
    Felicia5 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    8c93887 View commit details
    Browse the repository at this point in the history

  4. deleted looking for just apply keyword and we look for other words as… 

    … well e.g. delete
    @Felicia5
    Felicia5 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    aaa71c4 View commit details
    Browse the repository at this point in the history

  5. checking attributes, logic from alt-text rule

    @Felicia5
    Felicia5 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    7ef8737 View commit details
    Browse the repository at this point in the history

  6. return commands after each check are added

    @Felicia5
    Felicia5 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    7c4985f View commit details
    Browse the repository at this point in the history

  7. added more meaningful error messages

    @Felicia5
    Felicia5 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    56926b9 View commit details
    Browse the repository at this point in the history

  8. when tabindex AND role values are missing the error message should hi… 

    …ghlight that both are missing not just one
    @Felicia5
    Felicia5 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    4ac6140 View commit details
    Browse the repository at this point in the history

  9. corrected error messages, deleted unnecessary commented code parts

    @Felicia5
    Felicia5 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    c179d25 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. got rid off unnecessary comment and hasAccessibleChild util

    @Felicia5
    Felicia5 committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    eb4b893 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. before three messages

    @Felicia5
    Felicia5 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    71f135a View commit details
    Browse the repository at this point in the history

  2. basic tests passed - no variable, or custom elements

    @Felicia5
    Felicia5 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    d96254e View commit details
    Browse the repository at this point in the history

  3. before before changing logic of error messages

    @Felicia5
    Felicia5 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    3af1c4c View commit details
    Browse the repository at this point in the history

  4. added or case

    @Felicia5
    Felicia5 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    ceb1211 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. wrong attribute value and missing attribute

    @Felicia5
    Felicia5 committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    8abf804 View commit details
    Browse the repository at this point in the history

  2. testing what options, componentOptions, typeCheck and nodeType variab… 

    …les are again
    @Felicia5
    Felicia5 committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    737801b View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. see if it works without TextChildValue, created VariableChildValue in… 

    … comments
    @Felicia5
    Felicia5 committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    c763acb View commit details
    Browse the repository at this point in the history

  2. trial and error for looking at if variable value is equal to text app… 

    …ly - trying to access when expression.type='Identifier' in ast
    @Felicia5
    Felicia5 committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    f3f3588 View commit details
    Browse the repository at this point in the history

  3. <div>{apply}</div> trying to access variable apply inside curly brace… 

    …s AND trying accessing variable value in heading -hasAccessibleChild util
    @Felicia5
    Felicia5 committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    08d3aa5 View commit details
    Browse the repository at this point in the history

  4. hasAccessibleChild empty string is not linted neither when expression… 

    ….name is undefined
    @Felicia5
    Felicia5 committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    c404e78 View commit details
    Browse the repository at this point in the history

  5. added custom element tests

    @Felicia5
    Felicia5 committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    9165a02 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. markdown file finished

    @Felicia5
    Felicia5 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6ba1ebe View commit details
    Browse the repository at this point in the history