Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the jsx-a11y/lang rule to the recommended and strict presets #671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

astorije
Copy link
Contributor

It turns out that jsx-a11y/lang is the only rule not enabled in either recommended or strict presets.
I wasn't sure if it was intentional or accidental but I figured it would take me as much time to open an issue asking about it than opening a PR to suggest it. Do what you please with it :)

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a rule to a preset is a breaking change, so I suspect it was intentional. We can land this whenever something forces a major release.

@astorije
Copy link
Contributor Author

Absolutely agree with that, feel free to keep this PR open until the next major version, I'm in no rush :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.484% when pulling 8a4a737 on astorije:astorije/lang-recommended into 7bcea20 on evcohen:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.484% when pulling 8a4a737 on astorije:astorije/lang-recommended into 7bcea20 on evcohen:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants