fix(job): make ctx and env binding to Job instances to use in handle() #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplhomer
reviewed
Nov 17, 2023
| ); | ||
| } | ||
|
|
||
| async function handleQueueMessage(message: Message, ctx: ExecutionContext) { | ||
| async function handleQueueMessage<Env>(message: Message, ctx: ExecutionContext, env: Env) { | ||
| const instance = await hydrateInstanceFromQueuePayload( | ||
| message.body as MessagePayload |
There was a problem hiding this comment.
I think it would make more sense to pass ctx and env here as second or third args, since that function is responsible for hydrating an instance. (even if we only end up assigning it for Job instances). Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
envandctxparams available to Job instances. Resolves #56