chore(workflow): action to create pr in rnj #130
Conversation
Fixes for the Deeplinks implementation
| destination_repo: 'jolocom/react-native-jolocom' | ||
| destination_base_branch: 'master' | ||
| user_name: 'SBub' | ||
| user_email: '[email protected]' |
There was a problem hiding this comment.
I think that this must be impersonated somehow...
There was a problem hiding this comment.
100%, i.e. we have jolocom-dev user that can serve such a purpose
| uses: SBub/[email protected] | ||
|
|
||
| env: | ||
| API_TOKEN_GITHUB: ${{ secrets.API_TOKEN_GITHUB }} |
There was a problem hiding this comment.
Every devs must have such key with all exposed rights to pass this job? can it be impersonated as well? for example with jolocom dev acc?
There was a problem hiding this comment.
the API_TOKEN_GITHUB is a secret of the jolocom-sdk the action reads it from there
There was a problem hiding this comment.
Can't we have the check on the react-native-jolocom package instead of here, since this would have to be replicated for the jolocom-lib, jolocom typeorm, etc. ? Instead, we can maybe have an action on the rnj package which checks if any of these dependencies updated, and if they did, it would create a PR with either a minor or major update on rnj. For instance, there is this action https://github.com/marketplace/actions/dependencies-autoupdate which can be responsible for auto updating our jolocom dependencies and can create a PR in that case.
Good point 👍 . It looks like can be reached by 'Scheduled event' which will be triggered once a day for example to not overload CI... |
Description
This workflow will create a PR in
react-native-jolocomrepo when new updates are pushed to master. The assumption is that when we make a new release we merge things to master (we should actually sync about it). The only role of this action is to pass inputs to the underlying action SBub/create-outside-pr, which is adopted fork of another repo that creates PR using gh cli.create-outside-praction looks at thepackage.jsonof the repo where the action was triggered, reads its name and version and creates PR in destination repo (in this case react-native-jolocom) in the format:chore/bump-$PACKAGE_NAME-$PACAKGE_VERSION-$timestampwith valid title and description.Purpose
Let
react-native-jolocomknow when updates happened to its jolocom ssi dependenciesFurther steps
We would have to use this action for jolocom-lib and sdk-storage repos, so this action can be further abstracted
This PR in react-native-jolocom was generated with this action.