Fix testing of features at the workspace level #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test.sh script contains logic to avoid testing features that don't exist in the subcrates, but this logic breaks apart when run from the top level. Fix this by always running with the requested features at the top level.
Sometimes, Azure geolocation tests in pull requests fail with a 401, saying that the Maps key is wrong. However, this only happens to a test within the same PR run and only randomly, so the configuration is correct. Try to workaround this with retries, which are also a good idea to have because we are making the tests depend on an external service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test.sh script contains logic to avoid testing features that don't exist in the subcrates, but this logic breaks apart when run from the top level. Fix this by always running with the requested features at the top level.