Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use either Git submodules (preferable) or CMake FetchContent #46

Open
OPNA2608 opened this issue Aug 27, 2022 · 0 comments
Open

Use either Git submodules (preferable) or CMake FetchContent #46

OPNA2608 opened this issue Aug 27, 2022 · 0 comments

Comments

@OPNA2608
Copy link

There is a Git submodule (dependency fetching mechanism # 1) for JUCE that gets semi-regularly updated, but it's completely ignored by the CMake script which uses FetchContent (dependency fetching mechanism # 2) for JUCE and the other required dependencies instead.

Mixing these is weird because the submodule is essentially never used by CMake, it seems like a mistake? For me at least (trying to package this in a Linux/macOS package manager) it would be preferable to only use Git submodules and replace the FetchContent_* calls with add_subdirectory(<dependency> EXCLUDE_FROM_ALL) ones, because FetchContent isn't very compatible with the way we do fetching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant