fire: init at 1.0.0.3 #188515
Merged
fire: init at 1.0.0.3 #188515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
OPNA2608
commented
Aug 27, 2022
| }; | ||
|
|
||
| patches = [ | ||
| ./0001-Remove-FetchContent-usage.patch |
There was a problem hiding this comment.
Upstream is currently mixing Git submodules & CMake FetchContent, I've opened an issue asking them to decide on one (preferably submodules so we can just include them with fetchSubmodules): jerryuhoo/Fire#46
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1206 |
Needs at least 10.14 SDK on Darwin, so we need to switch to the 11.0 one. https://github.com/juce-framework/JUCE/blob/b08520c2de1771af3dfcbfbc0e0b6b0b5eb083b0/modules/juce_core/system/juce_TargetPlatform.h#L147-L148
|
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Packages Fire, a multi-band VST3 & AU distortion plugin.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes