Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use apache email validation instead of Regex #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jdftapi
Copy link

@jdftapi jdftapi commented Jul 7, 2021

Since the regex used in the ValidationUtils is not sufficient to recognize many RFC compliant email adresses (e.g. "[email protected]"), I replaced the regex validation with the EmailValidator from Apache. I also refactored some of the validation code to remove redundant lines.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant