-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable comparator in the environment when #368
Open
v1v
wants to merge
7
commits into
jenkinsci:master
Choose a base branch
from
v1v:feature/Environmentcomparator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
force-pushed
the
feature/Environmentcomparator
branch
from
December 11, 2019 20:27
2d55874
to
42ee792
Compare
As long as https://issues.jenkins-ci.org/browse/JENKINS-60466 isi not yet resolved we cannot rename paramet ers
v1v
commented
Mar 3, 2020
...insci/plugins/pipeline/modeldefinition/when/impl/EnvironmentConditional/help-comparator.html
Outdated
Show resolved
Hide resolved
…gins/pipeline/modeldefinition/when/impl/EnvironmentConditional/help-comparator.html
v1v
changed the title
WIP: enable comparator in the environment when
enable comparator in the environment when
Mar 3, 2020
v1v
commented
Mar 3, 2020
...in/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/EnvironmentConditional.java
Outdated
Show resolved
Hide resolved
…pipeline/modeldefinition/when/impl/EnvironmentConditional.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comparator
argument as already done withchangeset
,tag
andbranch
.help-*.html
.Further details
value
parameter withpattern
but unfortunately, it's a breaking change and there is no way to support it with thereadResolve
pattern neither with theCustomDescribableModel
pattern, further details: JENKINS-60466.