feat: add support of windows container images (2019 and 2022) #819
+242
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
This was referenced Sep 24, 2023
dduportal
changed the title
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
dduportal
commented
Sep 25, 2023
| if (compute_type == 'docker') { | ||
| String agentLabel = compute_type + '-' + packer_template | ||
| if (packer_template ==~ /ubuntu.*/) { | ||
| agentLabel = 'linux-amd64-docker' |
There was a problem hiding this comment.
Code review with @smerle33: missing arm64 case for Linux!
There was a problem hiding this comment.
Suggested change
| agentLabel = 'linux-amd64-docker' | |
| agentLabel = "linux-${cpu_architecture}-docker" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR superseds the initial experiment to build our custom Windows container images with packer (instead of https://github.com/jenkins-infra/docker-inbound-agents/) to continue the "All in One" project for easier maintenance.