chore(updatecli):Track ubuntu 22_04 AMD64 AZ images
#1507
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
jayfranco999
changed the title
ubuntu 22_04 AMD64 imagesubuntu 22_04 AMD64 AZ images
dduportal
reviewed
Nov 12, 2024
| @@ -17,6 +17,7 @@ build { | |||
| image_publisher = "canonical" | |||
| # List available SKUs with the command `az vm image list-skus --offer 0001-com-ubuntu-server-jammy --location eastus --publisher canonical --output table` | |||
| image_sku = local.az_instance_image_sku[var.architecture] | |||
| image_version = try(local.images_versions["azure"]["ubuntu"][var.agent_os_version][var.architecture], "N/A") | |||
There was a problem hiding this comment.
This line looks good to me 👍
Current image version in the YAML images definition file is latest. As such, the CI check uses the expected "latest" reference:
-> SourceImageName: '/subscriptions/****/providers/Microsoft.Compute/locations/eastus2/publishers/canonical/ArtifactTypes/vmimage/offers/0001-com-ubuntu-server-jammy/skus/22_04-lts-gen2/versions/latest'
dduportal
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Good work! Still some work is needed:
- Blocker: fix the
updateclierrors. It looks like the source responds with an empty string on the CI. Not sure if it is an updatecli error, AZ credential error, or something else. - Rebase the PR against the latest main reference
Comment on lines
+37
to
+39
| transformers: | ||
| - addprefix: '"' | ||
| - addsuffix: '"' |
There was a problem hiding this comment.
Did you test locally? If yes what was the result for your test?
On the CI side, it fails with the following error:
ERROR: something went wrong in "target#updateVersion" : something went wrong in target "updateVersion" : "validation error: transformer input is empty"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per jenkins-infra/helpdesk#4365 (comment)
This PR pins and tracks the latest AZ image for
ubuntu 22_04 AMD64