Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #500: Add language parameter to GetTvShowVideosAsync method #501

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix #500: Add language parameter to GetTvShowVideosAsync method #501

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35b084f
fix #500: Add language parameter to GetTvShowVideosAsync method
DineshSolanki Jul 8, 2024
8a61a9a
Refactor GetTvShowMethodInternal to include media language for videos…
DineshSolanki Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions TMDbLib/Client/TMDbClientTvShows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace TMDbLib.Client
{
public partial class TMDbClient
{
private async Task<T> GetTvShowMethodInternal<T>(int id, TvShowMethods tvShowMethod, string dateFormat = null, string language = null, string includeImageLanguage = null, int page = 0, CancellationToken cancellationToken = default) where T : new()
private async Task<T> GetTvShowMethodInternal<T>(int id, TvShowMethods tvShowMethod, string dateFormat = null, string language = null, string includeMediaLanguage = null, int page = 0, CancellationToken cancellationToken = default) where T : new()
{
RestRequest req = _client.Create("tv/{id}/{method}");
req.AddUrlSegment("id", id.ToString(CultureInfo.InvariantCulture));
Expand All @@ -35,10 +35,14 @@ public partial class TMDbClient
if (!string.IsNullOrWhiteSpace(language))
req.AddParameter("language", language);

includeImageLanguage ??= DefaultImageLanguage;
if (!string.IsNullOrWhiteSpace(includeImageLanguage))
req.AddParameter("include_image_language", includeImageLanguage);

includeMediaLanguage ??= DefaultImageLanguage;
if (!string.IsNullOrWhiteSpace(includeMediaLanguage))
{
req.AddParameter(
tvShowMethod == TvShowMethods.Videos ? "include_video_language" : "include_image_language",
includeMediaLanguage);
}

T resp = await req.GetOfT<T>(cancellationToken).ConfigureAwait(false);

return resp;
Expand Down Expand Up @@ -211,7 +215,7 @@ public async Task<ExternalIdsTvShow> GetTvShowExternalIdsAsync(int id, Cancellat
/// <param name="cancellationToken">A cancellation token</param>
public async Task<ImagesWithId> GetTvShowImagesAsync(int id, string language = null, string includeImageLanguage = null, CancellationToken cancellationToken = default)
{
return await GetTvShowMethodInternal<ImagesWithId>(id, TvShowMethods.Images, language: language, includeImageLanguage: includeImageLanguage, cancellationToken: cancellationToken).ConfigureAwait(false);
return await GetTvShowMethodInternal<ImagesWithId>(id, TvShowMethods.Images, language: language, includeMediaLanguage: includeImageLanguage, cancellationToken: cancellationToken).ConfigureAwait(false);
}

public async Task<SearchContainerWithId<ReviewBase>> GetTvShowReviewsAsync(int id, string language = null, int page = 0, CancellationToken cancellationToken = default)
Expand Down Expand Up @@ -315,9 +319,9 @@ public async Task<TranslationsContainerTv> GetTvShowTranslationsAsync(int id, Ca
return await GetTvShowMethodInternal<TranslationsContainerTv>(id, TvShowMethods.Translations, cancellationToken: cancellationToken).ConfigureAwait(false);
}

public async Task<ResultContainer<Video>> GetTvShowVideosAsync(int id, CancellationToken cancellationToken = default)
public async Task<ResultContainer<Video>> GetTvShowVideosAsync(int id, string includeMediaLanguage = null, CancellationToken cancellationToken = default)
{
return await GetTvShowMethodInternal<ResultContainer<Video>>(id, TvShowMethods.Videos, cancellationToken: cancellationToken).ConfigureAwait(false);
return await GetTvShowMethodInternal<ResultContainer<Video>>(id, TvShowMethods.Videos, includeMediaLanguage:includeMediaLanguage, cancellationToken: cancellationToken).ConfigureAwait(false);
}

public async Task<SingleResultContainer<Dictionary<string, WatchProviders>>> GetTvShowWatchProvidersAsync(int id, CancellationToken cancellationToken = default)
Expand Down
Loading