Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the TargetFrameworks #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the TargetFrameworks #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions TMDbLib/TMDbLib.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<Authors>LordMike;Naliath</Authors>
<TargetFrameworks>net45;netstandard2.1;netstandard2.0;netstandard1.2</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
<AssemblyName>TMDbLib</AssemblyName>
<PackageId>TMDbLib</PackageId>
<Description>.NET Client library for The Movie Database (https://www.themoviedb.org/)</Description>
Expand All @@ -25,13 +25,4 @@
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" PrivateAssets="compile" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
<Reference Include="Microsoft.CSharp" />
<PackageReference Include="System.Net.Http" Version="4.3.4" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.2' ">
<PackageReference Include="System.Net.Http" Version="4.3.4" />
</ItemGroup>

</Project>
4 changes: 2 additions & 2 deletions TMDbLibTests/TMDbLibTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<Import Project="..\_Imports\Test.targets" />

<PropertyGroup>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>

</PropertyGroup>

<ItemGroup>
Expand All @@ -18,7 +18,7 @@
<PackageReference Include="xunit" Version="2.5.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.1" PrivateAssets="All" />
<PackageReference Include="Verify.Xunit" Version="14.14.1" />
<PackageReference Include="Verify.Xunit" Version="17.10.2" />
</ItemGroup>

<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions TMDbLibTests/UtilityTests/TaggedImageConverterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ public async Task TestJsonTaggedImageConverter(int personId)
else if (item.MediaType == MediaType.Season)
Assert.IsType<SearchTvSeason>(item.Media);
else
Assert.False(true, $"Unexpected type {item.GetType().Name}");
Assert.Fail($"Unexpected type {item.GetType().Name}");
});
}
}
}
}
2 changes: 1 addition & 1 deletion TestApplication/TestApplication.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<Import Project="..\_Imports\Test.targets" />

<PropertyGroup>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>

<OutputType>Exe</OutputType>
</PropertyGroup>

Expand Down
Loading