Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend MediaType #435

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

angyanmark
Copy link
Contributor

@angyanmark angyanmark commented Mar 19, 2023

Fixes: #414, #415, #420, #430

This will do the trick, but it would be nicer if we could map two different enum values to the same enum.
Like this:

[EnumValue("episode")]
[EnumValue("tv_episode")]
Episode = 4,

or

[EnumValue("episode", "tv_episode")]
Episode = 4,

@LordMike
Copy link
Collaborator

Would one of you be interested in maintaining this library?

I'm no longer using TMDb, so it's a chore. :/

@angyanmark
Copy link
Contributor Author

I think the current pull requests can be accepted, they contain a lot of features and bug fixes.
I don't plan on using the library anymore either.

@cvium
Copy link
Member

cvium commented Aug 19, 2023

Would one of you be interested in maintaining this library?

I'm no longer using TMDb, so it's a chore. :/

@LordMike Hey. We've used your library for a while in Jellyfin and we might be willing to take over. Would you be willing to transfer the repo to us? Or would you prefer a fork?

@LordMike
Copy link
Collaborator

I could transfer it. I think that makes most sense.

  • I'd like the git history to be maintained, and an attribution made that I started the library
  • I'd like to keep being a contributor (member of) the project
  • I'll transfer the nuget access as well, so the package can keep being updated

Would this work?

@cvium
Copy link
Member

cvium commented Aug 22, 2023

Yes, that works for us.

@jakelandau
Copy link
Contributor

Are there any updates on the transfer of package maintenance to the Jellyfin project? As a downstream consumer of this package I haven't heard of any news in the Jellyfin #development channel on the discord server.

@LordMike
Copy link
Collaborator

I added @cvium as a member to this repo a few days ago - I do hope he got an email :P

I couldn't transfer the repo myself because of rights.

@LordMike
Copy link
Collaborator

I just checked - the invite was expired. I've reinvited.

@cvium
Copy link
Member

cvium commented Sep 13, 2023

Yes, sorry, I keep forgetting

@cvium
Copy link
Member

cvium commented Sep 16, 2023

@LordMike I think you need to give me permissions to transfer

@LordMike
Copy link
Collaborator

@cvium ok - so I think that for personal projects like this, there can be only one admin. At least, all the pictures I can find indicate a drop down for role, but its simply not present.

What I can do is transfer the project to you (which I can't because you already have a project named TMDbLib - delete that) and then you will be an admin. Or I can become an admin in Jellyfin and then have the permission to create projects there (which is required to do transfers).

Let me know.

@cvium
Copy link
Member

cvium commented Sep 16, 2023

@LordMike I have deleted my fork. I can't give you admin in Jellyfin. Even I'm not an admin there :)

@LordMike
Copy link
Collaborator

@cvium check your .. something .. there should be a transfer request.

@LordMike
Copy link
Collaborator

Aand, now it is at Jellyfin. Good job everyone! :)

@cvium
Copy link
Member

cvium commented Sep 16, 2023

The roundabout transfer is complete: https://github.com/jellyfin/TMDbLib. Unfortunately, our GH admin is asleep, so your permissions will be set up later

@LordMike
Copy link
Collaborator

We also need to transfer the NuGet package ownership. @cvium

@cvium
Copy link
Member

cvium commented Sep 16, 2023

We also need to transfer the NuGet package ownership. @cvium

I think we need @anthonylavado for that

@Bond-009
Copy link
Member

Bond-009 commented Sep 16, 2023

Isn't that just adding Jellyfin as an owner of the package?
https://www.nuget.org/profiles/Jellyfin
(TMDbLib > Manage Package > Owners)

@LordMike
Copy link
Collaborator

I have added jellyfin. There should be request awaiting approval somewhere.

@LordMike
Copy link
Collaborator

Well. It was accepted. I assume all is good and I can remove myself from the package?

@cvium cvium merged commit 17674ca into jellyfin:master Sep 22, 2023
@cvium cvium mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MediaType for episode changes to tv_episode
5 participants