fix flask-sqlalchemy regression #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing |
dwreeves
force-pushed
the
fix-regression-flask-sqlalchemy-3.0
branch
from
446d8c5
to
c6cc820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest, I have no idea how to make the tests pass for this repo for Flask-SQLAlchemy 3.x; I'd spent a few hours trying with no avail; it's more complicated than just running tests in a live app context. Sorry 😦 Raw SQL seems to work, but the ORM does not, is the extent of what I remember.
However, in my experience and despite the tests for this build not working, this does fix a regression for Flask-SQLAlchemy 3.0, as long as the end-user also yields the
SQLAlchemy()object in the app context.